Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: if upload moves commit to other branch, possibly update branch model head" #349

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

adrian-codecov
Copy link
Contributor

Reverts #345

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

Codecov Report

Merging #349 (9a446ec) into main (0b82d71) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   96.07%   96.07%   -0.01%     
==========================================
  Files         625      625              
  Lines       16206    16199       -7     
==========================================
- Hits        15570    15563       -7     
  Misses        636      636              
Flag Coverage Δ
unit 96.07% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 96.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
upload/helpers.py 94.02% <100.00%> (-0.17%) ⬇️

Impacted file tree graph

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b82d71) 95.70% compared to head (9a446ec) 95.70%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #349   +/-   ##
=====================================
  Coverage   95.70   95.70           
=====================================
  Files        740     740           
  Lines      16722   16715    -7     
=====================================
- Hits       16003   15996    -7     
  Misses       719     719           
Flag Coverage Δ
unit 96.07% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 96.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b82d71) 96.07% compared to head (9a446ec) 96.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   96.07%   96.07%   -0.01%     
==========================================
  Files         625      625              
  Lines       16206    16199       -7     
==========================================
- Hits        15570    15563       -7     
  Misses        636      636              
Flag Coverage Δ
unit 96.07% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 96.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrian-codecov adrian-codecov merged commit a9a1f25 into main Jan 20, 2024
20 of 21 checks passed
@adrian-codecov adrian-codecov deleted the revert-345-matt/fix-branch-move branch January 20, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants