Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update org token to check if user is authenticated #351

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eec38e0) 96.05% compared to head (140438a) 96.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         625      625           
  Lines       16195    16200    +5     
=======================================
+ Hits        15556    15561    +5     
  Misses        639      639           
Flag Coverage Δ
unit 96.05% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Jan 23, 2024

Codecov Report

Merging #351 (140438a) into main (eec38e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         625      625           
  Lines       16195    16200    +5     
=======================================
+ Hits        15556    15561    +5     
  Misses        639      639           
Flag Coverage Δ
unit 96.05% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...commands/owner/interactors/get_org_upload_token.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eec38e0) 95.70% compared to head (140438a) 95.70%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #351   +/-   ##
=====================================
  Coverage   95.70   95.70           
=====================================
  Files        740     740           
  Lines      16711   16716    +5     
=====================================
+ Hits       15993   15998    +5     
  Misses       718     718           
Flag Coverage Δ
unit 96.05% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RulaKhaled RulaKhaled merged commit 2e9e7c8 into main Jan 23, 2024
34 checks passed
@RulaKhaled RulaKhaled deleted the fix-org-token-vuln branch January 23, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants