Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add email to the stripe customer serializer #363

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

adrian-codecov
Copy link
Contributor

Purpose/Motivation

Forgot to add this when making the API ticket to change the billing email from the client

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a8f1ae) 96.08% compared to head (ab31b9c) 96.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         632      632           
  Lines       16409    16410    +1     
=======================================
+ Hits        15766    15767    +1     
  Misses        643      643           
Flag Coverage Δ
unit 96.08% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Jan 26, 2024

Codecov Report

Merging #363 (ab31b9c) into main (3a8f1ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         632      632           
  Lines       16409    16410    +1     
=======================================
+ Hits        15766    15767    +1     
  Misses        643      643           
Flag Coverage Δ
unit 96.08% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/owner/serializers.py 99.01% <100.00%> (+<0.01%) ⬆️

Impacted file tree graph

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a8f1ae) 95.75% compared to head (ab31b9c) 95.75%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #363   +/-   ##
=====================================
  Coverage   95.75   95.75           
=====================================
  Files        747     747           
  Lines      16927   16928    +1     
=====================================
+ Hits       16208   16209    +1     
  Misses       719     719           
Flag Coverage Δ
unit 96.08% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrian-codecov adrian-codecov merged commit daacd21 into main Jan 30, 2024
22 checks passed
@adrian-codecov adrian-codecov deleted the 168-surface-stripe-email-serializer branch January 30, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants