Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upload test results #367

Merged
merged 2 commits into from
Feb 12, 2024
Merged

build: upload test results #367

merged 2 commits into from
Feb 12, 2024

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Jan 29, 2024 •
edited
Loading

Uploads test results to codecov

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0f936e) 95.76% compared to head (babebf4) 95.53%.

Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #367     +/-   ##
=======================================
- Coverage   95.76   95.53   -0.23     
=======================================
  Files        749     749             
  Lines      17088   17082      -6     
=======================================
- Hits       16363   16318     -45     
- Misses       725     764     +39
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry marked this pull request as ready for review February 2, 2024 23:25
@joseph-sentry joseph-sentry force-pushed the joseph/upload-test-results branch from 01c9f6f to 56007fa Compare February 2, 2024 23:25
barnett-yuxiang
barnett-yuxiang reviewed Feb 5, 2024
View reviewed changes
Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1508e5) 96.07% compared to head (7506936) 96.07%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         633      633           
  Lines       16552    16552           
=======================================
  Hits        15902    15902           
  Misses        650      650
Flag Coverage Δ
unit 96.07% <ø> (ø)
unit-latest-uploader 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1508e5) 96.07% compared to head (7506936) 96.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         633      633           
  Lines       16552    16552           
=======================================
  Hits        15902    15902           
  Misses        650      650
Flag Coverage Δ
unit 96.07% <ø> (ø)
unit-latest-uploader 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

@joseph-sentry joseph-sentry force-pushed the joseph/upload-test-results branch from 0c02656 to babebf4 Compare February 8, 2024 16:55
joseph-sentry and others added 2 commits February 8, 2024 16:55
@joseph-sentry
build: upload test results
ace3f82 
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
@joseph-sentry
build: pass upload of test results always
7506936
@joseph-sentry joseph-sentry force-pushed the joseph/upload-test-results branch from babebf4 to 7506936 Compare February 8, 2024 21:55
@joseph-sentry joseph-sentry merged commit c1c13b0 into main Feb 12, 2024
19 of 20 checks passed
@joseph-sentry joseph-sentry deleted the joseph/upload-test-results branch February 12, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnett-yuxiang barnett-yuxiang barnett-yuxiang left review comments

@giovanni-guidini giovanni-guidini giovanni-guidini approved these changes

@adrian-codecov adrian-codecov Awaiting requested review from adrian-codecov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joseph-sentry @barnett-yuxiang @giovanni-guidini