fix: optimize n+1 query when creating upload #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-codecov
approved these changes
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 96.06% 96.07%
=======================================
Files 634 634
Lines 16538 16545 +7
=======================================
+ Hits 15888 15895 +7
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 96.06% 96.07%
=======================================
Files 634 634
Lines 16538 16545 +7
=======================================
+ Hits 15888 15895 +7
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We noticed that we query the flags from an upload inside the loop and decided to move that to the outside to reduce hits to the database
giovanni-guidini
force-pushed
the
gio/optimize-query
branch
from
d898366 to
1cc9149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that we query the flags from an upload inside the loop
and decided to move that to the outside to reduce hits to the database