Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add more users to test results rollout #380

Merged
merged 1 commit into from
Feb 8, 2024
Merged

chore: add more users to test results rollout #380

merged 1 commit into from
Feb 8, 2024

Conversation

joseph-sentry
Copy link
Contributor

Purpose/Motivation

We're adding more users to the test results feature rollout

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3124dbf) 96.07% compared to head (156e6ee) 96.07%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         634      634           
  Lines       16550    16550           
=======================================
  Hits        15900    15900           
  Misses        650      650
Flag Coverage Δ
unit 96.07% <ø> (ø)
unit-latest-uploader 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3124dbf) 96.07% compared to head (156e6ee) 96.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         634      634           
  Lines       16550    16550           
=======================================
  Hits        15900    15900           
  Misses        650      650
Flag Coverage Δ
unit 96.07% <ø> (ø)
unit-latest-uploader 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
utils/rollouts.py 100.00% <ø> (ø)

Impacted file tree graph

@joseph-sentry joseph-sentry force-pushed the joseph/add-to-test-results-rollouts branch 2 times, most recently from 49ec6cc to 836e9a3 Compare February 7, 2024 22:01
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df07ebd) 95.75% compared to head (836e9a3) 95.75%.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main    #380   +/-   ##
=====================================
  Coverage   95.75   95.75           
=====================================
  Files        749     749           
  Lines      17063   17063           
=====================================
  Hits       16338   16338           
  Misses       725     725
Flag Coverage Δ
unit 96.07% <ø> (-0.01%) ⬇️
unit-latest-uploader 96.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry
chore: add more users to test results rollout
156e6ee 
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
@joseph-sentry joseph-sentry force-pushed the joseph/add-to-test-results-rollouts branch from 836e9a3 to 156e6ee Compare February 8, 2024 15:23
rohan-at-sentry
rohan-at-sentry approved these changes Feb 8, 2024
View reviewed changes
Copy link

@rohan-at-sentry rohan-at-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-sentry joseph-sentry merged commit 58f75b1 into main Feb 8, 2024
20 checks passed
@joseph-sentry joseph-sentry deleted the joseph/add-to-test-results-rollouts branch February 8, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-at-sentry rohan-at-sentry rohan-at-sentry approved these changes

@eliatcodecov eliatcodecov eliatcodecov approved these changes

@giovanni-guidini giovanni-guidini Awaiting requested review from giovanni-guidini

@JerrySentry JerrySentry Awaiting requested review from JerrySentry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joseph-sentry @eliatcodecov @rohan-at-sentry