Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cryptography and starlette dependencies #391

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?

This PR bumps a couple of dependencies to close out https://github.com/codecov/internal-issues/issues/230
and https://github.com/codecov/internal-issues/issues/229

Links to relevant tickets

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1c13b0) 96.07% compared to head (b78d696) 96.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         633      633           
  Lines       16552    16552           
=======================================
  Hits        15902    15902           
  Misses        650      650           
Flag Coverage Δ
unit 96.07% <ø> (ø)
unit-latest-uploader 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1c13b0) 96.07% compared to head (b78d696) 96.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         633      633           
  Lines       16552    16552           
=======================================
  Hits        15902    15902           
  Misses        650      650           
Flag Coverage Δ
unit 96.07% <ø> (ø)
unit-latest-uploader 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review February 9, 2024 19:06
@rohitvinnakota-codecov rohitvinnakota-codecov merged commit aebd4b7 into main Feb 12, 2024
14 of 15 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/bump-deps-vuln229-230 branch February 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants