feat: Bundle Analysis v0.5 Update GraphQL schema #405
Conversation
| @@ -3,16 +3,18 @@ | |||
|
|
|||
There was a problem hiding this comment.
This file is all boilerplate imports
| @@ -0,0 +1,21 @@ | |||
| from graphql_api.helpers.ariadne import ariadne_load_local_graphql | |||
There was a problem hiding this comment.
More boilerplate imports and refactored the folder structure to be:
bundle_analysis/
base.py
report.py
comparison.py
before it was
bundle_analysis_comparison/
comparison.py
bundle_analysis_report/
report.py
| @@ -0,0 +1,38 @@ | |||
| type BundleSize { | |||
There was a problem hiding this comment.
All the new types here, except BundleReport is modified.
| @@ -0,0 +1,80 @@ | |||
| from typing import List, Mapping | |||
There was a problem hiding this comment.
Added lots of Unimplemented resolvers here for coming PRs and also implemented a new way to present size and load times. Also marked the old ways of calculating it to be removed when it is fully migrated on the FE.
| @@ -3,11 +3,10 @@ | |||
| from ariadne import ObjectType, UnionType | |||
|
|
|||
There was a problem hiding this comment.
similar to base.py, added implementation for new bundleData and marked old ones to be deprecated
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 96.08% 96.09% +0.01%
==========================================
Files 637 637
Lines 16598 16654 +56
==========================================
+ Hits 15948 16004 +56
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 96.08% 96.09% +0.01%
==========================================
Files 637 637
Lines 16598 16654 +56
==========================================
+ Hits 15948 16004 +56
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=======================================
+ Coverage 95.76 95.79 +0.03
=======================================
Files 753 757 +4
Lines 17118 17233 +115
=======================================
+ Hits 16393 16508 +115
Misses 725 725
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
Adds the new updated GQL schema for BA v0.5. Also implements the
bundleDatatype, a new format to retrieve size and load times. Many resolvers remain unimplemented for the coming PRs so that this doesn't get too big.Links to relevant tickets
codecov/engineering-team#1190
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.