-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user check to customer intent resolver #410
Add user check to customer intent resolver #410
Conversation
7ecbe57
to
c33dc65
Compare
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
=======================================
- Coverage 95.80 94.07 -1.73
=======================================
Files 757 757
Lines 17250 17653 +403
=======================================
+ Hits 16525 16606 +81
- Misses 725 1047 +322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
397c137
to
c33dc65
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 643 643
Lines 17120 17122 +2
=======================================
+ Hits 16446 16448 +2
Misses 674 674
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #410 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 643 643
Lines 17120 17122 +2
=======================================
+ Hits 16446 16448 +2
Misses 674 674
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…innakota/add-check-customer-intent-resolver
6bf9684
to
60b21e6
Compare
Purpose/Motivation
Fixes these issues on Sentry. The
user
subtype on the owner may be undefined so we will returnNone
for the customer intent in that case.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.