-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1173 add user measurements partitioned table #414
1173 add user measurements partitioned table #414
Conversation
('objects', psqlextra.manager.manager.PostgresManager()), | ||
], | ||
), | ||
psqlextra.backend.migrations.operations.add_default_partition.PostgresAddDefaultPartition( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could potentially get rid of this default partition, but doesn't hurt to leave it here as we learn more and use partitioning in prod
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 96.11% 96.09% -0.02%
==========================================
Files 637 640 +3
Lines 16823 16867 +44
==========================================
+ Hits 16169 16208 +39
- Misses 654 659 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention:
@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 96.11% 96.09% -0.02%
==========================================
Files 637 640 +3
Lines 16823 16867 +44
==========================================
+ Hits 16169 16208 +39
- Misses 654 659 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Purpose/Motivation
We're adding the ability to do database partitions. Our first use case is described here, codecov/engineering-team#1173.
What does this PR do?
django-postgres-extra
libraryUserMeasurement
modelNotes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.