Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use debian base images instead of alpine #416

Merged
merged 6 commits into from
Apr 15, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Feb 24, 2024

fixes codecov/engineering-team#1242

with an alpine/musl image we have to build more packages from source. grpcio takes an eternity to build for example

also apparently alpine/musl images have DNS resolution problems

this uses an official "slim" python image based on debian stable. from a quick glance at uncompressed image sizes on my local machine, this is actually 300mb smaller:
Screenshot 2024-02-23 at 7 48 56 PM
Screenshot 2024-02-23 at 7 48 34 PM

i have not rigorously tested this but it seems okay

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (db019c3) to head (fdc4ff3).

❗ Current head fdc4ff3 differs from pull request most recent head eb70a3f. Consider uploading reports for the commit eb70a3f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #416     +/-   ##
=======================================
- Coverage   95.79   95.78   -0.01     
=======================================
  Files        757     757             
  Lines      17293   17332     +39     
=======================================
+ Hits       16565   16601     +36     
- Misses       728     731      +3     
Flag Coverage Δ
unit 96.09% <ø> (+<0.01%) ⬆️
unit-latest-uploader 96.09% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (2d58144) to head (bd2b306).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         602      602           
  Lines       16218    16218           
=======================================
  Hits        14828    14828           
  Misses       1390     1390           
Flag Coverage Δ
unit 91.42% <ø> (ø)
unit-latest-uploader 91.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (2d58144) to head (bd2b306).

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         602      602           
  Lines       16218    16218           
=======================================
  Hits        14828    14828           
  Misses       1390     1390           
Flag Coverage Δ
unit 91.42% <ø> (ø)
unit-latest-uploader 91.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

@codecov-staging
Copy link

codecov-staging bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@trent-codecov trent-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good. Can you change the shebang for prod.sh etc? Then lets merge this to staging and test it out further.

@nora-codecov nora-codecov force-pushed the matt/debian-base-image branch 2 times, most recently from 2c4ccbb to ba7e2b7 Compare April 2, 2024 20:39
@nora-codecov nora-codecov force-pushed the matt/debian-base-image branch from ba7e2b7 to 1720c07 Compare April 9, 2024 17:00
@nora-codecov nora-codecov force-pushed the matt/debian-base-image branch from 1720c07 to 3e4dfdc Compare April 15, 2024 17:41
@nora-codecov nora-codecov force-pushed the matt/debian-base-image branch from 3e4dfdc to bd2b306 Compare April 15, 2024 19:19
@nora-codecov nora-codecov merged commit 8321d25 into main Apr 15, 2024
19 checks passed
@nora-codecov nora-codecov deleted the matt/debian-base-image branch April 15, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: move off of alpine base images for our docker containers
3 participants