-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use debian base images instead of alpine #416
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
=======================================
- Coverage 95.79 95.78 -0.01
=======================================
Files 757 757
Lines 17293 17332 +39
=======================================
+ Hits 16565 16601 +36
- Misses 728 731 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 602 602
Lines 16218 16218
=======================================
Hits 14828 14828
Misses 1390 1390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #416 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 602 602
Lines 16218 16218
=======================================
Hits 14828 14828
Misses 1390 1390
Flags with carried forward coverage won't be shown. Click here to find out more. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good. Can you change the shebang for prod.sh etc? Then lets merge this to staging and test it out further.
2c4ccbb
to
ba7e2b7
Compare
ba7e2b7
to
1720c07
Compare
1720c07
to
3e4dfdc
Compare
3e4dfdc
to
bd2b306
Compare
fixes codecov/engineering-team#1242
with an alpine/musl image we have to build more packages from source. grpcio takes an eternity to build for example
also apparently alpine/musl images have DNS resolution problems
this uses an official "slim" python image based on debian stable. from a quick glance at uncompressed image sizes on my local machine, this is actually 300mb smaller:
i have not rigorously tested this but it seems okay
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.