-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update to block users from accessing app if guest set to false for enterprise #417
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
- Coverage 96.06% 96.06% -0.01%
==========================================
Files 643 643
Lines 17117 17129 +12
==========================================
+ Hits 16444 16455 +11
- Misses 673 674 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention:
@@ Coverage Diff @@
## main #417 +/- ##
==========================================
- Coverage 96.06% 96.06% -0.01%
==========================================
Files 643 643
Lines 17117 17129 +12
==========================================
+ Hits 16444 16455 +11
- Misses 673 674 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
=======================================
+ Coverage 95.79 95.89 +0.10
=======================================
Files 757 763 +6
Lines 17293 18655 +1362
=======================================
+ Hits 16565 17889 +1324
- Misses 728 766 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RulaKhaled are we ready to merge this one? |
I was hoping to test this on staging before merging, but I guess there's no easy way to test API changes for self-hosted. So, yeah, I'll give this one last local test round and send it |
Purpose/Motivation
What is the feature? Why is this being done?
This change affects enterprise users only. We need a setting to disable guest access where it is enabled by default. We are looking to block guest users from accessing ALL enterprise pages and redirect them back to the login page, as we technically cannot block them there
Links to relevant tickets
codecov/feedback#252
closes: codecov/feedback#297
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.