Only delete tmp files relating to the right request #419
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 95.94% 95.95%
=======================================
Files 641 641
Lines 16954 16964 +10
=======================================
+ Hits 16267 16277 +10
Misses 687 687
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 95.94% 95.95%
=======================================
Files 641 641
Lines 16954 16964 +10
=======================================
+ Hits 16267 16277 +10
Misses 687 687
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=====================================
Coverage 95.82 95.82
=====================================
Files 757 757
Lines 17406 17416 +10
=====================================
+ Hits 16678 16688 +10
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
Instead of having any request clean up all bundle analysis SQLite files during the teardown step of the request handling, this change will only delete the exact SQLite file that a bundle analysis GQL request has created.
The issue this fixes is that on certain race conditions, a BA request in process (ie created a SQLite file created in /tmp, but haven't finished querying) might be paused for another request, and when the other request is finished it would delete the BA request that's in process. Finally when the context is switched back to the BA request it can no longer query the SQLite DB file because its not there now.
Links to relevant tickets
codecov/engineering-team#1268
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.