Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: updates for local development #424

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Chore: updates for local development #424

merged 1 commit into from
Feb 28, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

Figured out how to get the built-in Debug feature to work on my local IDE, required these few tweaks.

Links to relevant tickets

Full setup steps are in Notion.

What does this PR do?

  • api container can accept commands after startup
  • make build creates a required file that was missing
  • adds to .gitignore

Notes to Reviewer

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (f53d741) to head (be0b96e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         640      640           
  Lines       16867    16867           
=======================================
  Hits        16208    16208           
  Misses        659      659           
Flag Coverage Δ
unit 96.09% <100.00%> (ø)
unit-latest-uploader 96.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f53d741) 96.09% compared to head (be0b96e) 96.09%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         640      640           
  Lines       16867    16867           
=======================================
  Hits        16208    16208           
  Misses        659      659           
Flag Coverage Δ
unit 96.09% <100.00%> (ø)
unit-latest-uploader 96.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_test.py 100.00% <100.00%> (ø)

Impacted file tree graph

@nora-codecov nora-codecov merged commit 35fa8e4 into main Feb 28, 2024
20 checks passed
@nora-codecov nora-codecov deleted the nora/ide-setup-3 branch February 28, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants