fix: handle rate limit error in get pr info fn #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 96.05% 96.04% -0.02%
==========================================
Files 643 643
Lines 17080 17070 -10
==========================================
- Hits 16407 16395 -12
- Misses 673 675 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #433 +/- ##
=======================================
Coverage 96.05% 96.06%
=======================================
Files 643 643
Lines 17080 17093 +13
=======================================
+ Hits 16407 16420 +13
Misses 673 673
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
force-pushed
the
joseph/handle-rate-limit
branch
from
c8fce43 to
533b914
Compare
joseph-sentry
force-pushed
the
joseph/handle-rate-limit
branch
from
efcd98d to
cfd65ad
Compare
We want to handle receiving a 429 or 403 status code response from gh that is related to hitting the gh rate limit. now we do that when we try to get PR info while trying to auth with tokenless we will return a `exceptions.Throttled` which corresponds to a 429 status code
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Co-authored-by: Tom Hu <88201630+thomasrockhu-codecov@users.noreply.github.com>
joseph-sentry
force-pushed
the
joseph/handle-rate-limit
branch
from
cfd65ad to
9e0e8c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
adrian-codecov
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to handle receiving a 429 or 403
status code response from gh that is related
to hitting the gh rate limit.
now we do that when we try to get PR info while
trying to auth with tokenless
we will return a
exceptions.Throttledwhichcorresponds to a 429 status code
Links to relevant tickets
codecov/engineering-team#1247
What does this PR do?
TorngitRateLimitErroringet_pull_request_infoget_pull_request_infoto test it can handle receiving a 429 status code