Add ci_service field to upload endpoint

[joseph-sentry]

Links to relevant tickets

Fixes: codecov/engineering-team#1297

What does this PR do?

• Add a ci_service field to the UploadSerializer that is write_only

[codecov-staging]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

[codecov-public-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8512f8) 96.04% compared to head (8ed9ae3) 96.04%.

@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         643      643           
  Lines       17055    17057    +2     
=======================================
+ Hits        16380    16382    +2     
  Misses        675      675           

Flag	Coverage Δ
unit	96.04% <100.00%> (+<0.01%)	⬆️
unit-latest-uploader	96.04% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
upload/serializers.py	100.00% <100.00%> (ø)

[matt-codecov]

nit: there is a default argument on dict.pop(), you can do this in one step https://python-reference.readthedocs.io/en/latest/docs/dict/pop.html

[joseph-sentry]

I suppose I could do something like

validated_data.pop("version", default=None)

but I don't think it's clear that default is necessary or else this will throw an error if
version is not found

would it be cleaner to do what's below or to do what's above with a comment explaining that default is necessary?

try:
  validated_data.pop("version", default=None)
except KeyError:
  pass

[matt-codecov]

personally i think validated_data.pop("version", default=None) is clear enough. you don't assign the return value to anything so it's just getting rid of the value if it's in there

there's room to disagree there, though. if you want to be more explicit, i think tweak the current approach:

if "version" in validated_data:
    validated_data.pop("version")

i think the above is more "pythonic" + probably slightly more efficient (not that it matters here). checking for it in .keys() is probably O(n), but key in dict is probably O(1) haha

[codecov-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (f8512f8) to head (1040668).

❗ Current head 1040668 differs from pull request most recent head 8ed9ae3. Consider uploading reports for the commit 8ed9ae3 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         643      643           
  Lines       17055    17057    +2     
=======================================
+ Hits        16380    16382    +2     
  Misses        675      675           

Flag	Coverage Δ
unit	96.04% <100.00%> (+<0.01%)	⬆️
unit-latest-uploader	96.04% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (b99b186) to head (1040668).
Report is 1 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #436   +/-   ##
=====================================
  Coverage   95.75   95.75           
=====================================
  Files        765     765           
  Lines      17641   17643    +2     
=====================================
+ Hits       16892   16894    +2     
  Misses       749     749           

Flag	Coverage Δ
unit	96.04% <100.00%> (+<0.01%)	⬆️
unit-latest-uploader	96.04% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.