test: fix query measurements after 30 days test #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test started failing ater 2024-03-10 because the time at the query was not frozen to a specific date so it was using the system's actual time and the measurements were not a part of the last 30 days. Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 643 643
Lines 17093 17093
=======================================
Hits 16420 16420
Misses 673 673
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 643 643
Lines 17093 17093
=======================================
Hits 16420 16420
Misses 673 673
Flags with carried forward coverage won't be shown. Click here to find out more. |
ajay-sentry
reviewed
Mar 11, 2024
| @@ -94,9 +94,12 @@ def test_query_monthly_coverage_measurements_after_30_days(self): | |||
| assert len(all_measurements) == 8 | |||
|
|
|||
| plan_service = PlanService(current_org=owner) | |||
| freezer = freeze_time("2024-03-05T00:00:00") | |||
There was a problem hiding this comment.
nit: could you add a comment here for what this time signifies? similar to what we have on 81 and 87
ajay-sentry
approved these changes
Mar 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=====================================
Coverage 95.77 95.77
=====================================
Files 765 765
Lines 17679 17679
=====================================
Hits 16932 16932
Misses 747 747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RulaKhaled
pushed a commit
that referenced
this pull request
Mar 13, 2024
* test: fix query measurements after 30 days test This test started failing ater 2024-03-10 because the time at the query was not frozen to a specific date so it was using the system's actual time and the measurements were not a part of the last 30 days. * fix: add comments to clarify test fix Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
RulaKhaled
added a commit
that referenced
this pull request
Mar 13, 2024
* Test with states * second round * Okta stuff * quick fix for test * fixing tests * more tests * test: fix query measurements after 30 days test (#442) * test: fix query measurements after 30 days test This test started failing ater 2024-03-10 because the time at the query was not frozen to a specific date so it was using the system's actual time and the measurements were not a part of the last 30 days. * fix: add comments to clarify test fix Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io> * [admin] allow trial extension for orgs currently on trial (#438) Currently the admin app can extend a org trial, but only after they have expired and turned back to basic plan. This change allows the orgs' trials to be extended while they're still trialing. * Bundle Analysis: delete old code (#444) These fields are being deprecated by bundleData and bundleChange. The app is no longer calling these fields anymore, it is safe to remove now. * fix: use get_or_create in CommitSerializer.create (#437) * fix: use get_or_create in CommitSerializer.create there is a possibility of creating commits concurrently if that happens there is a possibility of getting an IntegrityError when trying to create the Commit object this commit solves this problem by using get_or_create to create the Commit object in the serializer * test: add test to make sure CommitSerializer create only creates one object in the db --------- Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io> * Revert "Bundle Analysis: delete old code (#444)" (#445) This reverts commit 7932e93. * Remove state after login --------- Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io> Co-authored-by: joseph-sentry <136376984+joseph-sentry@users.noreply.github.com> Co-authored-by: JerrySentry <142266253+JerrySentry@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
This test started failing ater 2024-03-10 because
the time at the query was not frozen to a specific date so it was using the system's actual time and
the measurements were not a part of the last 30 days.
What does this PR do?
Freezes time around monthly coverage measurements query in test