-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1427 use shared models for foundational apps #456
1427 use shared models for foundational apps #456
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
- Coverage 96.12% 91.42% -4.71%
==========================================
Files 652 602 -50
Lines 17305 16203 -1102
==========================================
- Hits 16635 14813 -1822
- Misses 670 1390 +720
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #456 +/- ##
==========================================
- Coverage 96.12% 91.42% -4.71%
==========================================
Files 652 602 -50
Lines 17305 16203 -1102
==========================================
- Hits 16635 14813 -1822
- Misses 670 1390 +720
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…hared-models-for-foundational-apps
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=======================================
- Coverage 95.85 95.76 -0.09
=======================================
Files 774 774
Lines 17880 17010 -870
=======================================
- Hits 17138 16288 -850
+ Misses 742 722 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…hared-models-for-foundational-apps
…hared-models-for-foundational-apps
…hared-models-for-foundational-apps
This reverts commit 40ad67e.
Purpose/Motivation
We're moving core, codecov_auth + reports models into shared. This is a PR to use the model related code there, + other things
Links to relevant tickets
codecov/engineering-team#1427
What does this PR do?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.