Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1427 use shared models for foundational apps #456

Merged
merged 21 commits into from
Apr 8, 2024

Conversation

adrian-codecov
Copy link
Contributor

Purpose/Motivation

We're moving core, codecov_auth + reports models into shared. This is a PR to use the model related code there, + other things

Links to relevant tickets

codecov/engineering-team#1427

What does this PR do?

  • Replaces model definitions w/ models in shared
  • Deletes tests that were moved to shared
  • Adjusts test imports in places where services were moved to shared

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@adrian-codecov adrian-codecov marked this pull request as ready for review April 2, 2024 19:36
@adrian-codecov adrian-codecov requested review from a team as code owners April 2, 2024 19:36
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (322b74a) to head (1586f39).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   96.12%   91.42%   -4.71%     
==========================================
  Files         652      602      -50     
  Lines       17305    16203    -1102     
==========================================
- Hits        16635    14813    -1822     
- Misses        670     1390     +720     
Flag Coverage Δ
unit 91.42% <100.00%> (-4.71%) ⬇️
unit-latest-uploader 91.42% <100.00%> (-4.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (322b74a) to head (1586f39).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   96.12%   91.42%   -4.71%     
==========================================
  Files         652      602      -50     
  Lines       17305    16203    -1102     
==========================================
- Hits        16635    14813    -1822     
- Misses        670     1390     +720     
Flag Coverage Δ
unit 91.42% <100.00%> (-4.71%) ⬇️
unit-latest-uploader 91.42% <100.00%> (-4.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_base.py 85.94% <100.00%> (+0.07%) ⬆️
codecov_auth/models.py 100.00% <100.00%> (+1.01%) ⬆️
core/models.py 100.00% <100.00%> (+5.28%) ⬆️
graphql_api/types/upload/upload.py 100.00% <100.00%> (ø)
legacy_migrations/management/commands/migrate.py 100.00% <100.00%> (+18.18%) ⬆️
legacy_migrations/models.py 100.00% <100.00%> (ø)
reports/models.py 100.00% <100.00%> (+2.64%) ⬆️

... and 177 files with indirect coverage changes

Impacted file tree graph

@adrian-codecov adrian-codecov requested a review from a team as a code owner April 3, 2024 21:29
codecov/settings_base.py Outdated Show resolved Hide resolved
core/migrations/__init__.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (f255726) to head (bfdf89c).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #456     +/-   ##
=======================================
- Coverage   95.85   95.76   -0.09     
=======================================
  Files        774     774             
  Lines      17880   17010    -870     
=======================================
- Hits       17138   16288    -850     
+ Misses       742     722     -20     
Flag Coverage Δ
unit 91.41% <100.00%> (-4.72%) ⬇️
unit-latest-uploader 91.41% <100.00%> (-4.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trent-codecov trent-codecov removed the request for review from a team April 8, 2024 18:28
@adrian-codecov adrian-codecov merged commit 40ad67e into main Apr 8, 2024
16 of 18 checks passed
@adrian-codecov adrian-codecov deleted the 1427-use-shared-models-for-foundational-apps branch April 8, 2024 21:19
adrian-codecov added a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants