[ezpz]: fix: uppercase enterprise env var name #473
Conversation
dev.sh
Outdated
| @@ -15,7 +15,7 @@ _start_gunicorn() { | |||
| if [[ "$STATSD_HOST" ]]; then | |||
| suffix="--statsd-host ${STATSD_HOST}:${STATSD_PORT}" | |||
| fi | |||
| if [[ "$RUN_ENV" == "enterprise" ]] || [[ "$RUN_ENV" == "DEV" ]]; then | |||
| if [[ "$RUN_ENV" == "ENTERPRISE" ]] || [[ "$RUN_ENV" == "DEV" ]]; then | |||
There was a problem hiding this comment.
I would make this either case insensitive compare or add another if. Just in case users are already accommodating for this being lower case.
There was a problem hiding this comment.
cc @giovanni-guidini for worker if that PR hasn't merged yet
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 643 643
Lines 17127 17127
=======================================
Hits 16451 16451
Misses 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #473 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 643 643
Lines 17127 17127
=======================================
Hits 16451 16451
Misses 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. |
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.