upgrade to 3.12 #483
upgrade to 3.12 #483
Conversation
giovanni-guidini
force-pushed
the
gio/update-3.12
branch
from
642aa53 to
65fc8c7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
+ Coverage 91.52% 91.54% +0.01%
==========================================
Files 602 601 -1
Lines 16396 16409 +13
==========================================
+ Hits 15006 15021 +15
+ Misses 1390 1388 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #483 +/- ##
==========================================
+ Coverage 91.52% 91.54% +0.01%
==========================================
Files 602 601 -1
Lines 16396 16409 +13
==========================================
+ Hits 15006 15021 +15
+ Misses 1390 1388 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes |
giovanni-guidini
changed the title
giovanni-guidini
force-pushed
the
gio/update-3.12
branch
from
65fc8c7 to
392198d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=======================================
+ Coverage 95.79 95.82 +0.03
=======================================
Files 777 777
Lines 17252 17266 +14
=======================================
+ Hits 16525 16544 +19
+ Misses 727 722 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -15,7 +15,7 @@ _start_gunicorn() { | |||
| if [[ "$STATSD_HOST" ]]; then | |||
| suffix="--statsd-host ${STATSD_HOST}:${STATSD_PORT}" | |||
| fi | |||
| if [[ "$RUN_ENV" == "ENTERPRISE" ]] || [[ "$RUN_ENV" == "enterprise" ]] || [[ "$RUN_ENV" == "DEV" ]]; then | |||
| if [ "$RUN_ENV" == "ENTERPRISE" ] || [ "$RUN_ENV" == "DEV" ]; then | |||
There was a problem hiding this comment.
Did you verify this works? Doing docker-compose up and ensuring the api pod runs the migrations script on its own would do it
There was a problem hiding this comment.
I did run the docker compose and verified that the api was running / I was able to access it. So... if that would do it I'd say I verified that it works, yes.
| @@ -1,11 +1,5 @@ | |||
| import os | |||
|
|
|||
| import sentry_sdk | |||
There was a problem hiding this comment.
Was this never used or?
There was a problem hiding this comment.
All these imports already exist in settings_base.py.
I assumed they were reduntant because settings_base is imported in settings_prod
giovanni-guidini
force-pushed
the
gio/update-3.12
branch
from
392198d to
924b073
Compare
giovanni-guidini
force-pushed
the
gio/update-3.12
branch
from
924b073 to
513057c
Compare
Chaging the base image (already updated to python 3.12)
giovanni-guidini
force-pushed
the
gio/update-3.12
branch
from
513057c to
4daf15c
Compare
Purpose/Motivation
What is the feature? Why is this being done?
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.