Update coverage/tree route to parse flags and components filters #503
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 599 599
Lines 16167 16177 +10
=======================================
+ Hits 14782 14792 +10
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #503 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 599 599
Lines 16167 16177 +10
=======================================
+ Hits 14782 14792 +10
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
=======================================
- Coverage 95.76 95.75 -0.01
=======================================
Files 774 774
Lines 17036 17046 +10
=======================================
+ Hits 16314 16322 +8
- Misses 722 724 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…codecov-api into rvinnakota/sunburst-fix
rohitvinnakota-codecov
force-pushed
the
rvinnakota/sunburst-fix
branch
from
d16ffb0 to
78f9f03
Compare
rohitvinnakota-codecov
force-pushed
the
rvinnakota/sunburst-fix
branch
from
907d580 to
a07d0b1
Compare
…codecov-api into rvinnakota/sunburst-fix
rohitvinnakota-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
| ] | ||
| build_report_from_commit.return_value = sample_report() | ||
| res = self._tree(components="Does_not_exist") | ||
| assert res.status_code == 404 |
There was a problem hiding this comment.
Should we also add 1 more test for the flag filtering?
API changes to propagate totals data to the sunburst chart on the front end.
The chart calls the
/coverage/tree endpoint, which does not currently filter on flags or components. This change makes it possible for it to do so. We do something similar in commit.py.There will be a follow up PR on gazebo that passes flags and components as query params.
Example call on staging
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.