-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: populate sessions when logging in #507
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 599 599
Lines 16193 16210 +17
=======================================
+ Hits 14808 14824 +16
- Misses 1385 1386 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 599 599
Lines 16193 16210 +17
=======================================
+ Hits 14808 14824 +16
- Misses 1385 1386 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with Jerry on a huddle, lgtm!
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
- Coverage 95.77 95.76 -0.01
=======================================
Files 774 774
Lines 17049 17066 +17
=======================================
+ Hits 16327 16343 +16
- Misses 722 723 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
What is the feature? Why is this being done?
Create a Session object that stores user info like IP and user agent when logging in. All sessions will be displayed on the UI in the settings/access page, can also click on revoke to delete the sessions which will logout the corresponding sessions. The Session is created whenever we create a DjangoSession object, for deletion the DjangoSession object is deleted which will cascade delete the Session object
Links to relevant tickets
fixes: codecov/engineering-team#1278
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.