fix: use proper measurement last uploaded #513
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 599 599
Lines 16186 16198 +12
=======================================
+ Hits 14801 14813 +12
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 599 599
Lines 16186 16198 +12
=======================================
+ Hits 14801 14813 +12
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -23,3 +27,18 @@ def component_measurements( | |||
| before=before, | |||
| branch=branch, | |||
| ) | |||
|
|
|||
|
|
|||
| def component_measurements_last_uploaded( | |||
There was a problem hiding this comment.
nit: thoughts on adding return types to these fns? would make it a little easier to review for me (as someone not super versed in python syntax lol)
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
=======================================
+ Coverage 95.76 95.77 +0.01
=======================================
Files 774 774
Lines 17042 17054 +12
=======================================
+ Hits 16320 16332 +12
Misses 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
Don't use the aggregated timestamp from the summaries table, instead use the timestamp from the measurements table, this returns the true timestamp of when the last upload was inserted into the timeseries DB.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.