-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle flare when commit report not available #520
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 599 599
Lines 16193 16195 +2
=======================================
+ Hits 14808 14810 +2
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #520 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 599 599
Lines 16193 16195 +2
=======================================
+ Hits 14808 14810 +2
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
=====================================
Coverage 95.77 95.77
=====================================
Files 774 774
Lines 17049 17051 +2
=====================================
+ Hits 16327 16329 +2
Misses 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
Fixes an internal server error when trying to retrieve the flare graph when the commit report is not available.
Links to relevant tickets
https://github.com/codecov/internal-issues/issues/395
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.