disable user-agent prometheus label to decrease load #521
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
=====================================
Coverage 95.77 95.77
=====================================
Files 774 774
Lines 17054 17049 -5
=====================================
- Hits 16332 16327 -5
Misses 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 91.44% 91.44% -0.01%
==========================================
Files 599 599
Lines 16198 16193 -5
==========================================
- Hits 14813 14808 -5
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 91.44% 91.44% -0.01%
==========================================
Files 599 599
Lines 16198 16193 -5
==========================================
- Hits 14813 14808 -5
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
hmm, not sure what a cheaper solution would look like |
re-enable in codecov/engineering-team#1654
apparently this label was bringing down prometheus so we are nuking it for now. there are so many distinct UAs that prometheus suffers from a combinatorial explosion of possible label combinations
the skeleton daniel set up to add/test this custom label is still good, just gotta tweak the actual value of the label to scrub some of the minutiae from it
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.