-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding logs for debugging #536
Conversation
5670090
to
f5866c4
Compare
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=====================================
Coverage 95.79 95.79
=====================================
Files 777 777
Lines 17232 17252 +20
=====================================
+ Hits 16506 16525 +19
- Misses 726 727 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 91.51% 91.52%
=======================================
Files 602 602
Lines 16376 16396 +20
=======================================
+ Hits 14987 15006 +19
- Misses 1389 1390 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 91.51% 91.52%
=======================================
Files 602 602
Lines 16376 16396 +20
=======================================
+ Hits 14987 15006 +19
- Misses 1389 1390 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure debug level logs will show up in the logs since i don't think our log level is at debug in prod and staging (but i'm not sure about other envs) but the changes lgtm
f5866c4
to
087f522
Compare
@joseph-sentry dang good call - I assumed we were collecting all logs but looking at the log explorer, looks like we aren't including |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6c0c108
to
3c7ce5f
Compare
3c7ce5f
to
138c3ce
Compare
Purpose/Motivation
Temporary logs for debugging OIDC auth