Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster tag for sentry tags #537

Merged
merged 1 commit into from
May 2, 2024
Merged

Add cluster tag for sentry tags #537

merged 1 commit into from
May 2, 2024

Conversation

trent-codecov
Copy link
Contributor

@trent-codecov trent-codecov commented May 2, 2024

Purpose/Motivation

What is the feature? Why is this being done?

Add cluster tag so we can tell where requests are in Sentry

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
codecov/settings_base.py 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.51%. Comparing base (ce47c18) to head (ff7f491).

✅ All tests successful. No failed tests found.

Files Patch % Lines
codecov/settings_base.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   91.52%   91.51%   -0.02%     
==========================================
  Files         602      602              
  Lines       16368    16370       +2     
==========================================
  Hits        14981    14981              
- Misses       1387     1389       +2     
Flag Coverage Δ
unit 91.51% <0.00%> (-0.02%) ⬇️
unit-latest-uploader 91.51% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.51%. Comparing base (ce47c18) to head (ff7f491).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   91.52%   91.51%   -0.02%     
==========================================
  Files         602      602              
  Lines       16368    16370       +2     
==========================================
  Hits        14981    14981              
- Misses       1387     1389       +2     
Flag Coverage Δ
unit 91.51% <0.00%> (-0.02%) ⬇️
unit-latest-uploader 91.51% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_base.py 84.78% <0.00%> (-0.94%) ⬇️

Impacted file tree graph

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.79%. Comparing base (ce47c18) to head (ff7f491).

✅ All tests successful. No failed tests found.

Files Patch % Lines
codecov/settings_base.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #537     +/-   ##
=======================================
- Coverage   95.80   95.79   -0.01     
=======================================
  Files        777     777             
  Lines      17224   17226      +2     
=======================================
  Hits       16500   16500             
- Misses       724     726      +2     
Flag Coverage Δ
unit 91.51% <0.00%> (-0.02%) ⬇️
unit-latest-uploader 91.51% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trent-codecov trent-codecov added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 8a02e67 May 2, 2024
13 of 21 checks passed
@trent-codecov trent-codecov deleted the trent/cluster-tag branch May 2, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants