Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy type checking for pre-commit #543

Merged
merged 2 commits into from
May 6, 2024
Merged

Add mypy type checking for pre-commit #543

merged 2 commits into from
May 6, 2024

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented May 6, 2024

Add a mypy step in pre-commit for type checking reporting only files that was touched in this commit. Currently failing the check does not forbid the commit from going through (though in the future it might).

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@JerrySentry JerrySentry changed the title May 06 precommit Add mypy type checking for pre-commit May 6, 2024
@codecov-qa
Copy link

codecov-qa bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (1e1cc99) to head (c058a0a).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         602      602           
  Lines       16376    16376           
=======================================
  Hits        14987    14987           
  Misses       1389     1389           
Flag Coverage Δ
unit 91.51% <ø> (ø)
unit-latest-uploader 91.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (1e1cc99) to head (c058a0a).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         602      602           
  Lines       16376    16376           
=======================================
  Hits        14987    14987           
  Misses       1389     1389           
Flag Coverage Δ
unit 91.51% <ø> (ø)
unit-latest-uploader 91.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

@JerrySentry JerrySentry marked this pull request as ready for review May 6, 2024 19:06
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (1e1cc99) to head (c058a0a).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #543   +/-   ##
=====================================
  Coverage   95.79   95.79           
=====================================
  Files        777     777           
  Lines      17232   17232           
=====================================
  Hits       16506   16506           
  Misses       726     726           
Flag Coverage Δ
unit 91.51% <ø> (ø)
unit-latest-uploader 91.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JerrySentry JerrySentry added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit ab808c1 May 6, 2024
19 checks passed
@JerrySentry JerrySentry deleted the may_06_precommit branch May 6, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants