Add GH action to do mypy check for patch #545
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 602 602
Lines 16396 16396
=======================================
Hits 15006 15006
Misses 1390 1390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=====================================
Coverage 95.79 95.79
=====================================
Files 777 777
Lines 17252 17252
=====================================
Hits 16525 16525
Misses 727 727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
.github/workflows/mypy.yml
Outdated
| jobs: | ||
| patch-typing-check: | ||
| name: Run Patch Type Check | ||
| uses: codecov/gha-workflows/.github/workflows/mypy.yml@may_06_mypy |
There was a problem hiding this comment.
TODO: change the pinned version once the gha-workflows PR is merged and a new release is created
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 602 602
Lines 16396 16396
=======================================
Hits 15006 15006
Misses 1390 1390
Flags with carried forward coverage won't be shown. Click here to find out more. |
Add mypy type checking in the GH CI. This does type checking for all files that are touched in the PR. This job runs at the same time the other main jobs run, however right now a failure on this does not block mergning (but it is encouraged to not fail the job), eventually it may start blocking merge to main.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.