Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run correct migration command #552

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

trent-codecov
Copy link
Contributor

Purpose/Motivation

Run correct migration command

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link
Contributor

@matt-codecov matt-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is a narrower command than the original? it would prevent the ts_telemetry migrations from running (although i will kill those whenever i get around to it)

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (1f86f07) to head (539fc6f).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         602      602           
  Lines       16396    16396           
=======================================
  Hits        15006    15006           
  Misses       1390     1390           
Flag Coverage Δ
unit 91.52% <ø> (ø)
unit-latest-uploader 91.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (1f86f07) to head (539fc6f).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         602      602           
  Lines       16396    16396           
=======================================
  Hits        15006    15006           
  Misses       1390     1390           
Flag Coverage Δ
unit 91.52% <ø> (ø)
unit-latest-uploader 91.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (1f86f07) to head (539fc6f).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #552   +/-   ##
=====================================
  Coverage   95.79   95.79           
=====================================
  Files        777     777           
  Lines      17252   17252           
=====================================
  Hits       16525   16525           
  Misses       727     727           
Flag Coverage Δ
unit 91.52% <ø> (ø)
unit-latest-uploader 91.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Matt said is correct, ts_telemetry wouldn't get ran, is that okay?

Also, would enterprise eventually want partitions? Not for this PR but to keep in mind

@trent-codecov
Copy link
Contributor Author

i think this is a narrower command than the original? it would prevent the ts_telemetry migrations from running (although i will kill those whenever i get around to it)

This is the same command we run in prod. So it seems it never got ran in our own deployment. By running without the app, it causes some errors.

@trent-codecov trent-codecov added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 4d08c2d May 8, 2024
22 checks passed
@trent-codecov trent-codecov deleted the trent/ts-migration-fix branch May 8, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants