-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run correct migration command #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is a narrower command than the original? it would prevent the ts_telemetry migrations from running (although i will kill those whenever i get around to it)
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 602 602
Lines 16396 16396
=======================================
Hits 15006 15006
Misses 1390 1390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 602 602
Lines 16396 16396
=======================================
Hits 15006 15006
Misses 1390 1390
Flags with carried forward coverage won't be shown. Click here to find out more. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
=====================================
Coverage 95.79 95.79
=====================================
Files 777 777
Lines 17252 17252
=====================================
Hits 16525 16525
Misses 727 727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Matt said is correct, ts_telemetry wouldn't get ran, is that okay?
Also, would enterprise eventually want partitions? Not for this PR but to keep in mind
This is the same command we run in prod. So it seems it never got ran in our own deployment. By running without the app, it causes some errors. |
Purpose/Motivation
Run correct migration command
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.