dev: Add Ruff to API, enable F541 as first rule

Makefile

@@ -44,19 +44,18 @@ lint:
 	make lint.run
 
 lint.install:
-	python -m pip install --upgrade pip
 	echo "Installing..."
-	pip install -Iv black==22.3.0 isort
+	pip install -Iv ruff
 
 lint.run:
-	black .
-	isort --profile black .
+	ruff check
+	ruff format
 
 lint.check:
 	echo "Linting..."
-	black --check .
-	echo "Sorting..."
-	isort --profile black --check .
+	ruff check
+	echo "Formatting..."
+	ruff format --check
 
 build.requirements:
 	# if docker pull succeeds, we have already build this version of

api/internal/feature/views.py

@@ -80,9 +80,7 @@ def post(self, request):
             # fetch flags not in cache
             missed_feature_flags = FeatureFlag.objects.filter(
                 name__in=cache_misses
-            ).prefetch_related(
-                "variants"
-            )  # include the feature flag variants aswell
+            ).prefetch_related("variants")  # include the feature flag variants aswell
 
             # evaluate the remaining flags
             for feature_flag in missed_feature_flags:
@@ -91,9 +89,9 @@ def post(self, request):
                 flag_evaluations[feature_flag.name] = Feature(
                     feature_flag.name, feature_flag, list(feature_flag.variants.all())
                 ).check_value_no_fetch(identifier=identifier)
-                flags_to_add_to_cache[
-                    get_flag_cache_redis_key(feature_flag.name)
-                ] = feature_flag
+                flags_to_add_to_cache[get_flag_cache_redis_key(feature_flag.name)] = (
+                    feature_flag
+                )
 
             # add the new flags to cache
             if len(flags_to_add_to_cache) >= 1:

api/internal/owner/serializers.py

@@ -134,7 +134,7 @@ def validate_value(self, value):
         if value not in plan_values:
             if value in SENTRY_PAID_USER_PLAN_REPRESENTATIONS:
                 log.warning(
-                    f"Non-Sentry user attempted to transition to Sentry plan",
+                    "Non-Sentry user attempted to transition to Sentry plan",
                     extra=dict(owner_id=current_owner.pk, plan=value),
                 )
             raise serializers.ValidationError(
@@ -149,27 +149,27 @@ def validate(self, plan):
         if plan["value"] in PAID_PLANS:
             if "quantity" not in plan:
                 raise serializers.ValidationError(
-                    f"Field 'quantity' required for updating to paid plans"
+                    "Field 'quantity' required for updating to paid plans"
                 )
             if plan["quantity"] <= 1:
                 raise serializers.ValidationError(
-                    f"Quantity for paid plan must be greater than 1"
+                    "Quantity for paid plan must be greater than 1"
                 )
 
             plan_service = PlanService(current_org=owner)
             is_org_trialing = plan_service.is_org_trialing
 
             if plan["quantity"] < owner.activated_user_count and not is_org_trialing:
                 raise serializers.ValidationError(
-                    f"Quantity cannot be lower than currently activated user count"
+                    "Quantity cannot be lower than currently activated user count"
                 )
             if (
                 plan["quantity"] == owner.plan_user_count
                 and plan["value"] == owner.plan
                 and not is_org_trialing
             ):
                 raise serializers.ValidationError(
-                    f"Quantity or plan for paid plan must be different from the existing one"
+                    "Quantity or plan for paid plan must be different from the existing one"
                 )
             if (
                 plan["value"] in TEAM_PLAN_REPRESENTATIONS

api/internal/tests/test_charts.py

@@ -47,7 +47,7 @@ def generate_random_totals(
         "m": misses,
         "c": coverage,
         "C": complexity,
-        "N": complexity_total
+        "N": complexity_total,
         # Not currenly used: diff, files, sessions, branches, methods
     }
     return totals

api/shared/compare/mixins.py

@@ -100,8 +100,8 @@ def retrieve(self, request, *args, **kwargs):
             elif comparison.pseudo_diff_adjusts_tracked_lines:
                 return Response(
                     data={
-                        "detail": f"Changes found in between %.7s...%.7s (pseudo...base) "
-                        f"which prevent comparing this pull request."
+                        "detail": "Changes found in between %.7s...%.7s (pseudo...base) "
+                        "which prevent comparing this pull request."
                         % (comparison.pull.compared_to, comparison.pull.base)
                     },
                     status=400,

api/shared/compare/serializers.py

@@ -203,7 +203,6 @@ def get_misses_count(self, impacted_file: ImpactedFile) -> serializers.IntegerFi
 
 
 class ImpactedFilesComparisonSerializer(ComparisonSerializer):
-
     files = serializers.SerializerMethodField()
     state = serializers.SerializerMethodField()
 

api/shared/permissions.py

@@ -3,8 +3,10 @@
 from asgiref.sync import async_to_sync
 from django.conf import settings
 from django.http import Http404
-from rest_framework.permissions import SAFE_METHODS  # ['GET', 'HEAD', 'OPTIONS']
-from rest_framework.permissions import BasePermission
+from rest_framework.permissions import (
+    SAFE_METHODS,  # ['GET', 'HEAD', 'OPTIONS']
+    BasePermission,
+)
 
 import services.self_hosted as self_hosted
 from api.shared.mixins import InternalPermissionsMixin, SuperPermissionsMixin
@@ -74,10 +76,10 @@ class RepositoryArtifactPermissions(BasePermission):
 
     permissions_service = RepositoryPermissionsService()
     message = (
-        f"Permission denied: some possible reasons for this are (1) the "
-        f"user doesn't have permission to view the specific resource, "
-        f"(2) the organization has a per-user plan or (3) the user is "
-        f"trying to view a private repo but is not activated."
+        "Permission denied: some possible reasons for this are (1) the "
+        "user doesn't have permission to view the specific resource, "
+        "(2) the organization has a per-user plan or (3) the user is "
+        "trying to view a private repo but is not activated."
     )
 
     def has_permission(self, request, view):

billing/migrations/0001_initial.py

@@ -6,7 +6,6 @@
 
 
 class Migration(migrations.Migration):
-
     initial = True
 
     dependencies = []

billing/tests/test_views.py

@@ -72,7 +72,7 @@ def _send_event(self, payload):
                 )
             },
             data=payload,
-            format="json"
+            format="json",
         )
 
     def test_invoice_payment_succeeded_sets_owner_delinquent_false(self):

billing/views.py

@@ -27,7 +27,7 @@
         if updated >= 1:
             log.info(f"Successfully updated info for {updated} customer(s)")
         else:
-            log.warning(f"Could not find customer")
+            log.warning("Could not find customer")
 
     def invoice_payment_succeeded(self, invoice):
         log.info(
@@ -113,7 +113,6 @@
             )
 
     def subscription_schedule_released(self, schedule):
-
         subscription = stripe.Subscription.retrieve(schedule["released_subscription"])
         owner = Owner.objects.get(ownerid=subscription.metadata.obo_organization)
         requesting_user_id = subscription.metadata.obo
@@ -201,8 +200,8 @@
         if not subscription_schedule_id:
             if subscription.status == "incomplete_expired":
                 log.info(
-                    f"Subscription updated with status change "
-                    f"to 'incomplete_expired' -- cancelling to free",
+                    "Subscription updated with status change "
+                    "to 'incomplete_expired' -- cancelling to free",
                     extra=dict(stripe_subscription_id=subscription.id),
                 )
                 plan_service.set_default_plan_data()
@@ -286,13 +285,13 @@
             return Response("Invalid signature", status=status.HTTP_400_BAD_REQUEST)
         if self.event.type not in StripeWebhookEvents.subscribed_events:
             log.warning(
-                f"Unsupported Stripe webhook event received, exiting",
+                "Unsupported Stripe webhook event received, exiting",
                 extra=dict(stripe_webhook_event=self.event.type),
             )
             return Response("Unsupported event type", status=204)
 
         log.info(
-            f"Stripe webhook event received",
+            "Stripe webhook event received",
             extra=dict(stripe_webhook_event=self.event.type),
         )
 

codecov/admin.py

@@ -16,9 +16,9 @@ def save_model(self, request, new_obj, form, change) -> None:
             for changed_field in form.changed_data:
                 prev_value = getattr(old_obj, changed_field)
                 new_value = getattr(new_obj, changed_field)
-                new_obj.changed_fields[
-                    changed_field
-                ] = f"prev value: {prev_value}, new value: {new_value}"
+                new_obj.changed_fields[changed_field] = (
+                    f"prev value: {prev_value}, new value: {new_value}"
+                )
 
         return super().save_model(request, new_obj, form, change)
 

codecov_auth/admin.py

@@ -176,7 +176,7 @@ def refresh(self, obj: OrganizationLevelToken):
         # 0 in this case refers to the 0th index of the inline
         # But there can only ever be 1 token per org, so it's fine to use that.
         return format_html(
-            f'<input type="checkbox" name="organization_tokens-0-REFRESH" id="id_organization_tokens-0-REFRESH">'
+            '<input type="checkbox" name="organization_tokens-0-REFRESH" id="id_organization_tokens-0-REFRESH">'
         )
 
     def has_change_permission(self, request, obj=None):

codecov_auth/migrations/0001_initial.py

@@ -14,7 +14,6 @@
 
 
 class Migration(migrations.Migration):
-
     initial = True
 
     dependencies = []

codecov_auth/migrations/0002_auto_20210817_1346.py

@@ -7,7 +7,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("core", "0004_pull_user_provided_base_sha"),
         ("codecov_auth", "0001_initial"),

codecov_auth/migrations/0003_auto_20210924_1003.py

@@ -9,7 +9,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [("codecov_auth", "0002_auto_20210817_1346")]
 
     operations = [

codecov_auth/migrations/0004_auto_20210930_1429.py

@@ -5,7 +5,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [("codecov_auth", "0003_auto_20210924_1003")]
 
     operations = [

codecov_auth/migrations/0006_auto_20211123_1535.py

@@ -8,7 +8,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [("codecov_auth", "0005_auto_20211029_1709")]
 
     operations = [

codecov_auth/migrations/0007_auto_20211129_1228.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [("codecov_auth", "0006_auto_20211123_1535")]
 
     operations = [

codecov_auth/migrations/0008_auto_20220119_1811.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [("codecov_auth", "0007_auto_20211129_1228")]
 
     operations = [

codecov_auth/migrations/0009_auto_20220511_1313.py

@@ -7,7 +7,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0008_auto_20220119_1811"),
     ]

codecov_auth/migrations/0010_owner_is_superuser.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0009_auto_20220511_1313"),
     ]

codecov_auth/migrations/0012_auto_20220531_1452.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0011_new_enterprise_plans"),
     ]

codecov_auth/migrations/0013_alter_owner_organizations.py

@@ -5,7 +5,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0012_auto_20220531_1452"),
     ]

codecov_auth/migrations/0014_alter_repositorytoken_token_type.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0013_alter_owner_organizations"),
     ]

codecov_auth/migrations/0015_organizationleveltoken.py

@@ -8,7 +8,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0014_alter_repositorytoken_token_type"),
     ]

codecov_auth/migrations/0016_alter_owner_admins.py

@@ -5,7 +5,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0015_organizationleveltoken"),
     ]

codecov_auth/migrations/0017_alter_organizationleveltoken_token_type.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0016_alter_owner_admins"),
     ]

codecov_auth/migrations/0018_usertoken.py

@@ -8,7 +8,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0017_alter_organizationleveltoken_token_type"),
     ]

codecov_auth/migrations/0019_alter_repositorytoken_token_type.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0018_usertoken"),
     ]

codecov_auth/migrations/0021_owner_max_upload_limit.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0020_ownerprofile_default_org"),
     ]

codecov_auth/migrations/0022_alter_owner_max_upload_limit.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0021_owner_max_upload_limit"),
     ]

codecov_auth/migrations/0023_auto_20230214_1129.py

@@ -5,7 +5,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0022_alter_owner_max_upload_limit"),
     ]

codecov_auth/migrations/0024_alter_owner_max_upload_limit.py

@@ -4,7 +4,6 @@
 
 
 class Migration(migrations.Migration):
-
     dependencies = [
         ("codecov_auth", "0023_auto_20230214_1129"),
     ]