Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve float() not accepting None value #558

Merged
merged 1 commit into from
May 13, 2024

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
Resolves: https://github.com/codecov/internal-issues/issues/462

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (7fc9bc5) to head (8020769).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         599      599           
  Lines       15947    15949    +2     
=======================================
+ Hits        14564    14566    +2     
  Misses       1383     1383           
Flag Coverage Δ
unit 91.32% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/public/v2/component/views.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (7fc9bc5) to head (8020769).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #558   +/-   ##
=====================================
  Coverage   95.82   95.82           
=====================================
  Files        777     777           
  Lines      17265   17267    +2     
=====================================
+ Hits       16543   16545    +2     
  Misses       722     722           
Flag Coverage Δ
unit 91.32% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (7fc9bc5) to head (8020769).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         599      599           
  Lines       15947    15949    +2     
=======================================
+ Hits        14564    14566    +2     
  Misses       1383     1383           
Flag Coverage Δ
unit 91.32% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RulaKhaled RulaKhaled added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit c93b652 May 13, 2024
21 of 22 checks passed
@RulaKhaled RulaKhaled deleted the resolve-api2-component-bug branch May 13, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants