Lower log severity level to remove Sentry noise #576
Conversation
| @@ -21,7 +21,7 @@ async def get_file_from_service(self, commit, path): | |||
| return content.get("content").decode("utf-8") | |||
| # TODO raise this to the API so we can handle it. | |||
| except Exception: | |||
| log.exception( | |||
| log.info( | |||
| "GetFileContentInteractor - exception raised", | |||
There was a problem hiding this comment.
Should the message change from "exception raised" as well?
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 599 599
Lines 15972 15972
=======================================
Hits 14592 14592
Misses 1380 1380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #576 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 599 599
Lines 15972 15972
=======================================
Hits 14592 14592
Misses 1380 1380
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
=====================================
Coverage 95.84 95.84
=====================================
Files 777 777
Lines 17290 17290
=====================================
Hits 16571 16571
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
fixes: https://github.com/codecov/internal-issues/issues/463
Change the severity level from
log.exceptiontolog.info, showing on exception level doesn't offer much as there's no actionable things for when fetching a non existent path on GH (we always return null when that happens), instead it would only spawn a Sentry error. Downgrading the severity level removes the Sentry noise.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.