-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: Enable most "E" rules for Ruff #579
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 91.40% 91.40% -0.01%
==========================================
Files 604 604
Lines 16052 16051 -1
==========================================
- Hits 14672 14671 -1
Misses 1380 1380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 91.40% 91.40% -0.01%
==========================================
Files 604 604
Lines 16052 16051 -1
==========================================
- Hits 14672 14671 -1
Misses 1380 1380
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=====================================
Coverage 95.86 95.86
=====================================
Files 782 782
Lines 17370 17369 -1
=====================================
- Hits 16651 16650 -1
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Purpose/Motivation
Part of the Lint Enhancement epic, codecov/engineering-team#1716, this PR aims to add a majority of the E rules to our ruff setup.
The ruff "E" rules are the "error" rules for the pycodestyle package. A majority of the fixes in this PR were for rules E721 and E722, around using type == instead of instanceof() and using bare excepts vs. explicit excepts.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.