Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repository deprecated resolver #582

Merged
merged 5 commits into from
May 30, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

With the completion of codecov/engineering-team#355, we can safely remove the resolver from the API. This PR closes codecov/engineering-team#356.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review May 27, 2024 20:42
@rohitvinnakota-codecov rohitvinnakota-codecov requested a review from a team as a code owner May 27, 2024 20:42
@codecov-qa
Copy link

codecov-qa bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (277b2cb) to head (0e3a70d).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #582   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         604      604           
  Lines       16110    16100   -10     
=======================================
- Hits        14729    14720    -9     
+ Misses       1381     1380    -1     
Flag Coverage Δ
unit 91.42% <ø> (+<0.01%) ⬆️
unit-latest-uploader 91.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/owner/owner.py 100.00% <ø> (+0.67%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov-public-qa bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (277b2cb) to head (0e3a70d).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #582   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         604      604           
  Lines       16110    16100   -10     
=======================================
- Hits        14729    14720    -9     
+ Misses       1381     1380    -1     
Flag Coverage Δ
unit 91.42% <ø> (+<0.01%) ⬆️
unit-latest-uploader 91.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/owner/owner.py 100.00% <ø> (+0.67%) ⬆️

Impacted file tree graph

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (277b2cb) to head (0e3a70d).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #582        +/-   ##
================================================
+ Coverage   95.86000   95.87000   +0.01000     
================================================
  Files           782        782                
  Lines         17428      17418        -10     
================================================
- Hits          16708      16699         -9     
+ Misses          720        719         -1     
Flag Coverage Δ
unit 91.42% <ø> (+<0.01%) ⬆️
unit-latest-uploader 91.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RulaKhaled RulaKhaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want us to test it on staging to make sure everything works as expected but i know staging has been down for a while :// I would wait until it's up and do a quick test round but i'll leave this up to you!

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin good

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit a40c42b May 30, 2024
21 of 22 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/remove-repo-depracted branch May 30, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove repositoryDeprecated resolver
3 participants