-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove repository deprecated resolver #582
Remove repository deprecated resolver #582
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #582 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 604 604
Lines 16110 16100 -10
=======================================
- Hits 14729 14720 -9
+ Misses 1381 1380 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #582 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 604 604
Lines 16110 16100 -10
=======================================
- Hits 14729 14720 -9
+ Misses 1381 1380 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
================================================
+ Coverage 95.86000 95.87000 +0.01000
================================================
Files 782 782
Lines 17428 17418 -10
================================================
- Hits 16708 16699 -9
+ Misses 720 719 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want us to test it on staging to make sure everything works as expected but i know staging has been down for a while :// I would wait until it's up and do a quick test round but i'll leave this up to you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lookin good
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
With the completion of codecov/engineering-team#355, we can safely remove the resolver from the API. This PR closes codecov/engineering-team#356.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.