Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regenerate repo upload token mutation #583

Merged
merged 20 commits into from
Jun 5, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented May 27, 2024

Adds a mutation that allows a user to regenerate a repository level upload token. This should replace the internal REST endpoint. A follow up PR will be made in gazebo to update hook logic to use this mutation and one more here to remove the old code once we ensure it is no longer in use.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (557388d) to head (d6fe51c).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #583        +/-   ##
================================================
+ Coverage   95.90000   95.91000   +0.01000     
================================================
  Files           790        793         +3     
  Lines         17600      17638        +38     
================================================
+ Hits          16880      16918        +38     
  Misses          720        720                
Flag Coverage Δ
unit 91.53% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.53% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (557388d) to head (d6fe51c).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   91.51%   91.53%   +0.01%     
==========================================
  Files         612      615       +3     
  Lines       16282    16320      +38     
==========================================
+ Hits        14901    14939      +38     
  Misses       1381     1381              
Flag Coverage Δ
unit 91.53% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.53% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../interactors/regenerate_repository_upload_token.py 100.00% <100.00%> (ø)
core/commands/repository/repository.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/__init__.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/mutation.py 100.00% <100.00%> (ø)
...ion/regenerate_repository_upload_token/__init__.py 100.00% <100.00%> (ø)
...upload_token/regenerate_repository_upload_token.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov-public-qa bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (557388d) to head (d6fe51c).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   91.51%   91.53%   +0.01%     
==========================================
  Files         612      615       +3     
  Lines       16282    16320      +38     
==========================================
+ Hits        14901    14939      +38     
  Misses       1381     1381              
Flag Coverage Δ
unit 91.53% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.53% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../interactors/regenerate_repository_upload_token.py 100.00% <100.00%> (ø)
core/commands/repository/repository.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/__init__.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/mutation.py 100.00% <100.00%> (ø)
...ion/regenerate_repository_upload_token/__init__.py 100.00% <100.00%> (ø)
...upload_token/regenerate_repository_upload_token.py 100.00% <100.00%> (ø)

Impacted file tree graph

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [draft] Add regenerate repo upload token mutation Add regenerate repo upload token mutation Jun 3, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review June 3, 2024 17:15
@rohitvinnakota-codecov rohitvinnakota-codecov requested a review from a team as a code owner June 3, 2024 17:15
@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 160c874 Jun 5, 2024
21 of 22 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/add-regen-repo-upload-token branch June 5, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants