Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for 1238: collect latency in seconds not nanoseconds #585

Merged
merged 4 commits into from
May 28, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

Adjust latency units

Links to relevant tickets

codecov/engineering-team#1238

@nora-codecov nora-codecov requested a review from a team as a code owner May 28, 2024 20:46
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.43%. Comparing base (f1a4eee) to head (fc07617).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files         604      604           
  Lines       16108    16108           
=======================================
  Hits        14728    14728           
  Misses       1380     1380           
Flag Coverage Δ
unit 91.43% <100.00%> (ø)
unit-latest-uploader 91.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/views.py 98.01% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.43%. Comparing base (f1a4eee) to head (fc07617).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files         604      604           
  Lines       16108    16108           
=======================================
  Hits        14728    14728           
  Misses       1380     1380           
Flag Coverage Δ
unit 91.43% <100.00%> (ø)
unit-latest-uploader 91.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/views.py 98.01% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (f1a4eee) to head (fc07617).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #585   +/-   ##
=====================================
  Coverage   95.87   95.87           
=====================================
  Files        782     782           
  Lines      17426   17426           
=====================================
  Hits       16707   16707           
  Misses       719     719           
Flag Coverage Δ
unit 91.43% <100.00%> (ø)
unit-latest-uploader 91.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov enabled auto-merge May 28, 2024 21:04
@nora-codecov nora-codecov added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 4be4921 May 28, 2024
21 of 22 checks passed
@nora-codecov nora-codecov deleted the nora/1238 branch May 28, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants