-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: Add W, PLC, PLE Ruff Rules #591
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #591 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 604 604
Lines 16100 16100
=======================================
Hits 14720 14720
Misses 1380 1380
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #591 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 604 604
Lines 16100 16100
=======================================
Hits 14720 14720
Misses 1380 1380
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
===========================================
Coverage 95.87000 95.87000
===========================================
Files 782 782
Lines 17418 17418
===========================================
Hits 16699 16699
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
Part of the lint enhancement epic, this PR aims to add the Pycodestyle warning rules, and the Pylint Convention and Pylint Error rules.
These can be found here:
A majority of the fixes were related to whitespace (rules W291, and W293) as well as invalid escape sequences (W605)
There was a single instance of PLC3002, and a few instances of PLE0101
Links to relevant tickets
Closes codecov/engineering-team#1844
What does this PR do?
This PR adds the rules listed above and fixes any errors that stemmed from them.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.