Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused Invoice GQL fields #598

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

ajay-sentry
Copy link
Contributor

Purpose/Motivation

Removes the unused invoice fields that aren't being referenced anymore in gazebo. Since we're exposing all the fields in GQL now, it is increasingly important to only expose fields that we intend to use.

Links to relevant tickets

closes codecov/engineering-team#1847

What does this PR do?

Went through gazebo and confirmed the fields that were being used when pulled off the invoice model. There were 6 unused fields:

  • invoicePDF
  • currency
  • customerAddress
  • amountRemaining
  • periodStart
  • customerShipping

Of these, I removed invoicePDF, amountRemaining and customerShipping. I decided it maybe worthwhile keeping both currency and customerAddress since we have some initiatives coming up that will need those fields shown on the UI

Screenshot 2024-06-03 at 11 49 11 AM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@ajay-sentry ajay-sentry requested a review from a team as a code owner June 3, 2024 19:00
@ajay-sentry ajay-sentry changed the title Ajay/1847 remove unused invoice fields chore: Remove unused Invoice GQL fields Jun 3, 2024
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (77c9904) to head (fe25fa8).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files         606      606           
  Lines       16194    16184   -10     
=======================================
- Hits        14812    14803    -9     
+ Misses       1382     1381    -1     
Flag Coverage Δ
unit 91.46% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/invoice/invoice.py 98.38% <100.00%> (+1.16%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (77c9904) to head (fe25fa8).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files         606      606           
  Lines       16194    16184   -10     
=======================================
- Hits        14812    14803    -9     
+ Misses       1382     1381    -1     
Flag Coverage Δ
unit 91.46% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/invoice/invoice.py 98.38% <100.00%> (+1.16%) ⬆️

Impacted file tree graph

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (77c9904) to head (fe25fa8).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #598   +/-   ##
===========================================
  Coverage   95.88000   95.88000           
===========================================
  Files           784        784           
  Lines         17512      17502   -10     
===========================================
- Hits          16791      16782    -9     
+ Misses          721        720    -1     
Flag Coverage Δ
unit 91.46% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajay-sentry ajay-sentry added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit e2e3cef Jun 3, 2024
22 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/1847-remove-unused-invoice-fields branch June 3, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Unused Fields from Invoice GQL resolvers
2 participants