Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add VAT to checkout session #607

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Jun 7, 2024

Purpose/Motivation

Adds the VAT information field to the stripe checkout session, this is to allow user's part of businesses to accurately represent their tax information, particularly for users outside of the US.

Related stripe docs: https://docs.stripe.com/tax/checkout/tax-ids

Closes codecov/engineering-team#1868

NOTE: This doesn't affect anything outside of the stripe customer object, or anything outside of the stripe session.

Screenshots

Screen.Recording.2024-06-06.at.5.09.35.PM.mov

Screenshot 2024-06-06 at 5 46 37 PM
Screenshot 2024-06-06 at 5 47 31 PM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (9b8d730) to head (268a4d1).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         615      615           
  Lines       16370    16370           
=======================================
  Hits        14977    14977           
  Misses       1393     1393           
Flag Coverage Δ
unit 91.49% <ø> (ø)
unit-latest-uploader 91.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
services/billing.py 92.33% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (9b8d730) to head (268a4d1).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         615      615           
  Lines       16370    16370           
=======================================
  Hits        14977    14977           
  Misses       1393     1393           
Flag Coverage Δ
unit 91.49% <ø> (ø)
unit-latest-uploader 91.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
services/billing.py 92.33% <ø> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (9b8d730) to head (268a4d1).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #607   +/-   ##
===========================================
  Coverage   95.92000   95.92000           
===========================================
  Files           793        793           
  Lines         17688      17688           
===========================================
  Hits          16968      16968           
  Misses          720        720           
Flag Coverage Δ
unit 91.49% <ø> (ø)
unit-latest-uploader 91.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajay-sentry ajay-sentry added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 4355328 Jun 7, 2024
21 of 22 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/1868-vat-checkout-session branch June 7, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add VAT to checkout session
2 participants