-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add GQL mutation to store event metrics #620
[feat] Add GQL mutation to store event metrics #620
Conversation
@ai-review-prompt-prod |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
================================================
+ Coverage 95.92000 95.93000 +0.01000
================================================
Files 793 796 +3
Lines 17741 17779 +38
================================================
+ Hits 17018 17056 +38
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3bd5a67
to
1527332
Compare
1527332
to
b45e555
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #620 +/- ##
==========================================
+ Coverage 91.48% 91.50% +0.01%
==========================================
Files 615 618 +3
Lines 16424 16462 +38
==========================================
+ Hits 15026 15064 +38
Misses 1398 1398
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #620 +/- ##
==========================================
+ Coverage 91.48% 91.50% +0.01%
==========================================
Files 615 618 +3
Lines 16424 16462 +38
==========================================
+ Hits 15026 15064 +38
Misses 1398 1398
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just the minor stuff with event vs event_name, potentially typing event from str -> event enum
…hub.com/codecov/codecov-api into rvinnakota/create-metric-store-mutation
Purpose/Motivation
This PR closes codecov/engineering-team#1829
Adds a GQL mutation that will exclusively be used by gazebo to track page visits and button clicks for onboarding metrics. This setup is designed to fail silently and interfere with the regular flow as little as possible.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.