Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add GQL mutation to store event metrics #620

Merged
merged 15 commits into from
Jun 19, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Jun 14, 2024

Purpose/Motivation

This PR closes codecov/engineering-team#1829

Adds a GQL mutation that will exclusively be used by gazebo to track page visits and button clicks for onboarding metrics. This setup is designed to fail silently and interfere with the regular flow as little as possible.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@rohitvinnakota-codecov
Copy link
Contributor Author

@ai-review-prompt-prod

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (6efefaf) to head (8e41e12).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #620        +/-   ##
================================================
+ Coverage   95.92000   95.93000   +0.01000     
================================================
  Files           793        796         +3     
  Lines         17741      17779        +38     
================================================
+ Hits          17018      17056        +38     
  Misses          723        723                
Flag Coverage Δ
unit 91.50% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.50% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohitvinnakota-codecov rohitvinnakota-codecov force-pushed the rvinnakota/create-metric-store-mutation branch from 3bd5a67 to 1527332 Compare June 14, 2024 17:21
@rohitvinnakota-codecov rohitvinnakota-codecov force-pushed the rvinnakota/create-metric-store-mutation branch from 1527332 to b45e555 Compare June 14, 2024 17:31
@codecov-qa
Copy link

codecov-qa bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (6efefaf) to head (8e41e12).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   91.48%   91.50%   +0.01%     
==========================================
  Files         615      618       +3     
  Lines       16424    16462      +38     
==========================================
+ Hits        15026    15064      +38     
  Misses       1398     1398              
Flag Coverage Δ
unit 91.50% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.50% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_base.py 85.02% <ø> (ø)
...commands/owner/interactors/store_codecov_metric.py 100.00% <100.00%> (ø)
codecov_auth/commands/owner/owner.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/__init__.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/mutation.py 100.00% <100.00%> (ø)
...api/types/mutation/store_event_metrics/__init__.py 100.00% <100.00%> (ø)
...utation/store_event_metrics/store_event_metrics.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@codecov-notifications
Copy link

codecov-notifications bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

codecov-public-qa bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (6efefaf) to head (8e41e12).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   91.48%   91.50%   +0.01%     
==========================================
  Files         615      618       +3     
  Lines       16424    16462      +38     
==========================================
+ Hits        15026    15064      +38     
  Misses       1398     1398              
Flag Coverage Δ
unit 91.50% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.50% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov/settings_base.py 85.02% <ø> (ø)
...commands/owner/interactors/store_codecov_metric.py 100.00% <100.00%> (ø)
codecov_auth/commands/owner/owner.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/__init__.py 100.00% <100.00%> (ø)
graphql_api/types/mutation/mutation.py 100.00% <100.00%> (ø)
...api/types/mutation/store_event_metrics/__init__.py 100.00% <100.00%> (ø)
...utation/store_event_metrics/store_event_metrics.py 100.00% <100.00%> (ø)

Impacted file tree graph

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review June 14, 2024 20:31
@rohitvinnakota-codecov rohitvinnakota-codecov requested a review from a team as a code owner June 14, 2024 20:31
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just the minor stuff with event vs event_name, potentially typing event from str -> event enum

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit 1787236 Jun 19, 2024
21 of 22 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/create-metric-store-mutation branch June 19, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Metrics][API] Create a GQL mutation to update the user metrics table
2 participants