Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add signal to dispatch sync task to gcloud #625

Merged
merged 7 commits into from
Jun 25, 2024

Conversation

adrian-codecov
Copy link
Contributor

Purpose/Motivation

Shelter needs access to a commit's branch. We can detect when a commit has an update (or create) and check if the branch meets the criteria for branches we want to save for tokenless in shelter. This change adds that signal to update the commit collection in GCP.

Pending on codecov/shared#253

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (1438016) to head (d3f19c9).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #625   +/-   ##
===========================================
  Coverage   95.94000   95.94000           
===========================================
  Files           799        799           
  Lines         17832      17842   +10     
===========================================
+ Hits          17109      17119   +10     
  Misses          723        723           
Flag Coverage Δ
unit 91.54% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (1438016) to head (d3f19c9).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   91.53%   91.54%           
=======================================
  Files         621      621           
  Lines       16515    16525   +10     
=======================================
+ Hits        15117    15127   +10     
  Misses       1398     1398           
Flag Coverage Δ
unit 91.54% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/signals.py 100.00% <100.00%> (ø)
core/signals.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov-public-qa bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (1438016) to head (d3f19c9).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   91.53%   91.54%           
=======================================
  Files         621      621           
  Lines       16515    16525   +10     
=======================================
+ Hits        15117    15127   +10     
  Misses       1398     1398           
Flag Coverage Δ
unit 91.54% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/signals.py 100.00% <100.00%> (ø)
core/signals.py 100.00% <100.00%> (ø)

Impacted file tree graph

@@ -31,7 +29,7 @@ def _get_pubsub_publisher():
@receiver(
post_save, sender=OrganizationLevelToken, dispatch_uid="shelter_sync_org_token"
)
def update_repository(sender, instance: OrganizationLevelToken, **kwargs):
def update_org_token(sender, instance: OrganizationLevelToken, **kwargs):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just renaming, was probably a copy paste that wasn't renamed at the time

@adrian-codecov adrian-codecov enabled auto-merge June 25, 2024 20:06
@adrian-codecov adrian-codecov added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 263efa7 Jun 25, 2024
21 of 22 checks passed
@adrian-codecov adrian-codecov deleted the shelter-118-add-branch-token-cacher branch June 25, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants