-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Store "Logged in with" user metrics #626
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
================================================
+ Coverage 95.93000 95.94000 +0.01000
================================================
Files 799 799
Lines 17807 17813 +6
================================================
+ Hits 17084 17090 +6
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #626 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 621 621
Lines 16490 16496 +6
=======================================
+ Hits 15092 15098 +6
Misses 1398 1398
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #626 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 621 621
Lines 16490 16496 +6
=======================================
+ Hits 15092 15098 +6
Misses 1398 1398
Flags with carried forward coverage won't be shown. Click here to find out more.
|
codecov_auth/views/gitlab.py
Outdated
UserOnboardingMetricsService.create_user_onboarding_metric( | ||
org_id=user.ownerid, event="INSTALLED_APP", payload={"login": "gitlab"} | ||
) | ||
print("WE PAST THI") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose/Motivation
Eng design: https://www.notion.so/sentry/Eng-Design-Tracking-Codecov-user-signup-to-first-commit-conversion-rate-6097411516f84563820276aafe3436ea
Stores metrics for when users login with a specific provider.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.