Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Tax Information to Resolver and Serializer #627

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

ajay-sentry
Copy link
Contributor

Purpose/Motivation

This PR aims to expose taxInformation on the customer and invoice objects for our invoice graphQL model, and account-details REST endpoint.

These will be used purely for "read only" behavior on Gazebo, for showing on the plan and invoice page.

Stripe Invoice Docs: https://docs.stripe.com/api/invoices
Strip Customer Docs: https://docs.stripe.com/api/customers/object

Links to relevant tickets

Closes codecov/engineering-team#1869

Notes to Reviewer

Had to extend the scope when we were fetching customer info from stripe to also include the tax information

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@ajay-sentry ajay-sentry requested a review from a team as a code owner June 20, 2024 15:38
@codecov-qa
Copy link

codecov-qa bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (8ab87fd) to head (520c8d9).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         620      620           
  Lines       16478    16482    +4     
=======================================
+ Hits        15080    15084    +4     
  Misses       1398     1398           
Flag Coverage Δ
unit 91.51% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/owner/serializers.py 99.02% <100.00%> (+<0.01%) ⬆️
graphql_api/types/invoice/invoice.py 98.46% <100.00%> (+0.07%) ⬆️
services/billing.py 92.44% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (8ab87fd) to head (520c8d9).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         620      620           
  Lines       16478    16482    +4     
=======================================
+ Hits        15080    15084    +4     
  Misses       1398     1398           
Flag Coverage Δ
unit 91.51% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/owner/serializers.py 99.02% <100.00%> (+<0.01%) ⬆️
graphql_api/types/invoice/invoice.py 98.46% <100.00%> (+0.07%) ⬆️
services/billing.py 92.44% <ø> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (8ab87fd) to head (520c8d9).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #627   +/-   ##
===========================================
  Coverage   95.93000   95.93000           
===========================================
  Files           798        798           
  Lines         17795      17799    +4     
===========================================
+ Hits          17072      17076    +4     
  Misses          723        723           
Flag Coverage Δ
unit 91.51% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajay-sentry ajay-sentry added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 965f943 Jun 20, 2024
21 of 22 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/Tax-info-additions branch June 20, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Add Tax Info to Serializer and Resolvers
2 participants