Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix GlobalUploadToken auth #631

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix: Fix GlobalUploadToken auth #631

merged 1 commit into from
Jun 24, 2024

Conversation

giovanni-guidini
Copy link
Contributor

Some methods were never finished.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Some methods were never finished.
@giovanni-guidini giovanni-guidini requested a review from a team June 24, 2024 10:54
@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
codecov_auth/authentication/repo_auth.py 95.23% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.52%. Comparing base (c3824bd) to head (030305c).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   91.52%   91.52%   -0.01%     
==========================================
  Files         620      621       +1     
  Lines       16474    16490      +16     
==========================================
+ Hits        15078    15092      +14     
- Misses       1396     1398       +2     
Flag Coverage Δ
unit 91.52% <97.36%> (-0.01%) ⬇️
unit-latest-uploader 91.52% <97.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/authentication/helpers.py 100.00% <100.00%> (ø)
codecov_auth/authentication/repo_auth.py 95.81% <95.23%> (-1.07%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Codecov Report

Attention: Patch coverage is 97.36842% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.52%. Comparing base (c3824bd) to head (030305c).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   91.52%   91.52%   -0.01%     
==========================================
  Files         620      621       +1     
  Lines       16474    16490      +16     
==========================================
+ Hits        15078    15092      +14     
- Misses       1396     1398       +2     
Flag Coverage Δ
unit 91.52% <97.36%> (-0.01%) ⬇️
unit-latest-uploader 91.52% <97.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/authentication/helpers.py 100.00% <100.00%> (ø)
codecov_auth/authentication/repo_auth.py 95.81% <95.23%> (-1.07%) ⬇️

Impacted file tree graph

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.93%. Comparing base (c3824bd) to head (030305c).

✅ All tests successful. No failed tests found.

Files Patch % Lines
codecov_auth/authentication/repo_auth.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##               main       #631        +/-   ##
================================================
- Coverage   95.94000   95.93000   -0.01000     
================================================
  Files           798        799         +1     
  Lines         17791      17807        +16     
================================================
+ Hits          17070      17084        +14     
- Misses          721        723         +2     
Flag Coverage Δ
unit 91.52% <97.36%> (-0.01%) ⬇️
unit-latest-uploader 91.52% <97.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 196de23 Jun 24, 2024
20 of 22 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/fix-gut branch June 24, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants