bundle analysis: add asset filtering #633
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #633 +/- ##
==========================================
+ Coverage 91.53% 91.54% +0.01%
==========================================
Files 621 621
Lines 16533 16556 +23
==========================================
+ Hits 15134 15157 +23
Misses 1399 1399
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #633 +/- ##
==========================================
+ Coverage 91.53% 91.54% +0.01%
==========================================
Files 621 621
Lines 16533 16556 +23
==========================================
+ Hits 15134 15157 +23
Misses 1399 1399
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
===========================================
Coverage 95.94000 95.94000
===========================================
Files 799 799
Lines 17850 17873 +23
===========================================
+ Hits 17126 17149 +23
Misses 724 724
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| if BundleLoadTypes.ENTRY in load_types and ( | ||
| BundleLoadTypes.INITIAL in load_types or BundleLoadTypes.LAZY in load_types | ||
| ): | ||
| chunk_entry = None |
There was a problem hiding this comment.
if looking to retrieve by ENTRY or one of INITIAL/LAZY then it just cancels out.
| elif BundleLoadTypes.INITIAL in load_types: | ||
| chunk_initial = True | ||
| elif BundleLoadTypes.LAZY in load_types: | ||
| chunk_initial = False |
There was a problem hiding this comment.
Lgtm, nit: make filtering fns chunk_entry/_initial for readability
closes codecov/engineering-team#1898
passes the GQL filter options downstream to use the filtering capabilities provided in shared modules.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.