[fix] Handle empty upload state #636
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
===========================================
Coverage 95.94000 95.94000
===========================================
Files 799 799
Lines 17832 17834 +2
===========================================
+ Hits 17109 17111 +2
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rohitvinnakota-codecov
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #636 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 621 621
Lines 16515 16517 +2
=======================================
+ Hits 15117 15119 +2
Misses 1398 1398
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #636 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 621 621
Lines 16515 16517 +2
=======================================
+ Hits 15117 15119 +2
Misses 1398 1398
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Purpose/Motivation
We are seeing a bunch of Sentry errors
where
'' is not a valid UploadStateso we will default to an error state if it does not exist.No front end logic will need to be changed as this leverages existing upload states.
The plan is to release and monitor for Sentry errors.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.