-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add resolvers to fetch github rate limit status #638
[feat] Add resolvers to fetch github rate limit status #638
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 91.60% 91.61% +0.01%
==========================================
Files 630 630
Lines 16739 16761 +22
==========================================
+ Hits 15334 15356 +22
Misses 1405 1405
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 91.60% 91.61% +0.01%
==========================================
Files 630 630
Lines 16739 16761 +22
==========================================
+ Hits 15334 15356 +22
Misses 1405 1405
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
================================================
+ Coverage 95.95000 95.96000 +0.01000
================================================
Files 808 808
Lines 18056 18078 +22
================================================
+ Hits 17326 17348 +22
Misses 730 730
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…innakota/surface-gh-rate-limit-errors
140b491
to
32afbdf
Compare
@ai-review-prompt-prod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion, otherwise approved
This PR closes codecov/engineering-team#1971
Following up from codecov/shared#269, call the rate limit service to determine to the user is rate limited either on an owner or repo level.
These resolvers will be checked on the front-end to decide communication of rate limited GH status to the user.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.