Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add resolvers to fetch github rate limit status #638

Merged
merged 14 commits into from
Jul 11, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Jun 26, 2024

This PR closes codecov/engineering-team#1971

Following up from codecov/shared#269, call the rate limit service to determine to the user is rate limited either on an owner or repo level.

These resolvers will be checked on the front-end to decide communication of rate limited GH status to the user.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.61%. Comparing base (0c0b14b) to head (9938a63).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
+ Coverage   91.60%   91.61%   +0.01%     
==========================================
  Files         630      630              
  Lines       16739    16761      +22     
==========================================
+ Hits        15334    15356      +22     
  Misses       1405     1405              
Flag Coverage Δ
unit 91.61% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/owner/owner.py 100.00% <100.00%> (ø)
graphql_api/types/repository/repository.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov-public-qa bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.61%. Comparing base (0c0b14b) to head (9938a63).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
+ Coverage   91.60%   91.61%   +0.01%     
==========================================
  Files         630      630              
  Lines       16739    16761      +22     
==========================================
+ Hits        15334    15356      +22     
  Misses       1405     1405              
Flag Coverage Δ
unit 91.61% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/owner/owner.py 100.00% <100.00%> (ø)
graphql_api/types/repository/repository.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (0c0b14b) to head (9938a63).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #638        +/-   ##
================================================
+ Coverage   95.95000   95.96000   +0.01000     
================================================
  Files           808        808                
  Lines         18056      18078        +22     
================================================
+ Hits          17326      17348        +22     
  Misses          730        730                
Flag Coverage Δ
unit 91.61% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 91.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [draft] Add skeleton code to fetch github rate limit status [draft] Add resolvers to fetch github rate limit status Jul 8, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [draft] Add resolvers to fetch github rate limit status [feat] Add resolvers to fetch github rate limit status Jul 8, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review July 9, 2024 19:48
@rohitvinnakota-codecov rohitvinnakota-codecov requested a review from a team as a code owner July 9, 2024 19:48
@rohitvinnakota-codecov
Copy link
Contributor Author

@ai-review-prompt-prod

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion, otherwise approved

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 56269e3 Jul 11, 2024
21 of 22 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/surface-gh-rate-limit-errors branch July 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Call shared check redis for rate limit function as a GQL resolver
3 participants