feat: Public test results API #643
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 91.49% 91.60% +0.11%
==========================================
Files 615 630 +15
Lines 16370 16739 +369
==========================================
+ Hits 14977 15334 +357
- Misses 1393 1405 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 62 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 91.49% 91.60% +0.11%
==========================================
Files 615 630 +15
Lines 16370 16739 +369
==========================================
+ Hits 14977 15334 +357
- Misses 1393 1405 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 62 files with indirect coverage changes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
================================================
+ Coverage 95.92000 96.09000 +0.17000
================================================
Files 793 808 +15
Lines 17688 19094 +1406
================================================
+ Hits 16968 18348 +1380
- Misses 720 746 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| filter_backends = [DjangoFilterBackend] | ||
| filterset_class = TestResultsFilters | ||
|
|
||
| def get_queryset(self): |
There was a problem hiding this comment.
Would it be right if the entire function just be?
def get_queryset(self):
return TestInstance.objects.filter(repoid=self.repo.repoid)
It should be the case that a Repository instance would always have a repoid.
Also return TestInstance.objects.none() would this return None when the callers would always expect an iterable?
Purpose/Motivation
What is the feature? Why is this being done?
Links to relevant tickets
codecov/engineering-team#1975
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.