Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculate coverage with 2 decimal places rounding down #645

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

JerrySentry
Copy link
Contributor

closes https://github.com/codecov/internal-issues/issues/511

Always round down the coverage % to 2 decimal places, this is to align with PR comments

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
utils/__init__.py 70.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.53%. Comparing base (7a2b8df) to head (94dd4a2).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   91.54%   91.53%   -0.02%     
==========================================
  Files         621      621              
  Lines       16555    16568      +13     
==========================================
+ Hits        15156    15166      +10     
- Misses       1399     1402       +3     
Flag Coverage Δ
unit 91.53% <81.25%> (-0.02%) ⬇️
unit-latest-uploader 91.53% <81.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/chart/views.py 86.36% <100.00%> (+0.31%) ⬆️
api/public/v2/component/views.py 100.00% <100.00%> (ø)
api/shared/commit/serializers.py 100.00% <100.00%> (ø)
utils/__init__.py 83.33% <70.00%> (-16.67%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 91.53%. Comparing base (7a2b8df) to head (94dd4a2).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   91.54%   91.53%   -0.02%     
==========================================
  Files         621      621              
  Lines       16555    16568      +13     
==========================================
+ Hits        15156    15166      +10     
- Misses       1399     1402       +3     
Flag Coverage Δ
unit 91.53% <81.25%> (-0.02%) ⬇️
unit-latest-uploader 91.53% <81.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/chart/views.py 86.36% <100.00%> (+0.31%) ⬆️
api/public/v2/component/views.py 100.00% <100.00%> (ø)
api/shared/commit/serializers.py 100.00% <100.00%> (ø)
utils/__init__.py 83.33% <70.00%> (-16.67%) ⬇️

Impacted file tree graph

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.93%. Comparing base (7a2b8df) to head (94dd4a2).

✅ All tests successful. No failed tests found.

Files Patch % Lines
utils/__init__.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##               main       #645        +/-   ##
================================================
- Coverage   95.94000   95.93000   -0.01000     
================================================
  Files           799        799                
  Lines         17872      17885        +13     
================================================
+ Hits          17148      17158        +10     
- Misses          724        727         +3     
Flag Coverage Δ
unit 91.53% <81.25%> (-0.02%) ⬇️
unit-latest-uploader 91.53% <81.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JerrySentry JerrySentry added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 5b60ee8 Jun 27, 2024
15 of 22 checks passed
@JerrySentry JerrySentry deleted the jun_27_decimals branch June 27, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants